Add zero-division checks to stdMath.percentDelta overloads #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorking7
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
onbjerg
previously approved these changes
Sep 23, 2025
zerosnacks
reviewed
Oct 6, 2025
zerosnacks
reviewed
Oct 6, 2025
|
@zerosnacks any updates? |
0xrusowsky
approved these changes
Oct 10, 2025
|
@viktorking7 i've just approved and triggered the CI. once everything green it will auto-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
stdMath.percentDelta(uint256,uint256)andstdMath.percentDelta(int256,int256).requirechecks with a concise error message and brief comments.